Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply ordered-import rule on multiline import statements #1344

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented Dec 21, 2022

PR Type

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The eslint rule 'ish-custom-rules/ordered-imports' doesn't order multiline import statements.

import {
  c,
  b,
  a,
} from @test

What Is the New Behavior?

The eslint rule bug should be fixed.

import {
  a,
  b,
  c,
} from @test

Does this PR Introduce a Breaking Change?

[ ] Yes
[ x ] No

Other Information

AB#82031

@shauke shauke added this to the 3.2 milestone Dec 22, 2022
@shauke shauke merged commit 5887c41 into develop Dec 22, 2022
@shauke shauke deleted the bugfix/ordered-imports branch December 22, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants