Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: formly - add the legend element to the fieldset, add legend class attribute #1354

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

andreassteinmann
Copy link
Collaborator

@andreassteinmann andreassteinmann commented Jan 11, 2023

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The formly type ish-fieldset-field does not support a legend tag.

Issue Number: Closes #

What Is the New Behavior?

The legend tag can be added by using the templateOptions at the type ish-fieldset-field. It is also possible to assign a specific class to the legend.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#82502

@andreassteinmann andreassteinmann changed the title feat: add the legend element to the fieldset, add legend class attrib… feat: add the legend element to the fieldset, add legend class attribute Jan 11, 2023
@andreassteinmann andreassteinmann changed the title feat: add the legend element to the fieldset, add legend class attribute feat: formly - add the legend element to the fieldset, add legend class attribute Jan 11, 2023
@shauke shauke requested a review from Eisie96 January 12, 2023 14:16
@shauke shauke assigned andreassteinmann and unassigned Eisie96 Jan 12, 2023
@shauke shauke removed the request for review from Eisie96 January 12, 2023 14:17
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the legend, we haven't even used the legend in our code yet and have to check if it works. Thank you

@SGrueber SGrueber added the enhancement Enhancement to an existing feature label Jan 23, 2023
@SGrueber SGrueber added this to the 3.3 milestone Jan 23, 2023
@SGrueber SGrueber merged commit 256bd7f into develop Jan 23, 2023
@SGrueber SGrueber deleted the feature/formly-add-legend-to-fieldset branch January 23, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants