-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add title for status checkboxes #1383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned for 3 active checkboxes.
SGrueber
changed the title
chore: title props for checkboxes
feat: add title for status checkboxes
Mar 6, 2023
SGrueber
requested changes
Mar 6, 2023
.../organization-management/src/app/components/user-profile-form/user-profile-form.component.ts
Show resolved
Hide resolved
src/app/extensions/punchout/shared/punchout-user-form/punchout-user-form.component.ts
Show resolved
Hide resolved
...hared/formly/wrappers/horizontal-checkbox-wrapper/horizontal-checkbox-wrapper.component.html
Outdated
Show resolved
Hide resolved
...hared/formly/wrappers/horizontal-checkbox-wrapper/horizontal-checkbox-wrapper.component.html
Outdated
Show resolved
Hide resolved
...hared/formly/wrappers/horizontal-checkbox-wrapper/horizontal-checkbox-wrapper.component.html
Outdated
Show resolved
Hide resolved
...hared/formly/wrappers/horizontal-checkbox-wrapper/horizontal-checkbox-wrapper.component.html
Outdated
Show resolved
Hide resolved
.../shared/formly/wrappers/horizontal-checkbox-wrapper/horizontal-checkbox-wrapper.component.ts
Outdated
Show resolved
Hide resolved
...hared/formly/wrappers/horizontal-checkbox-wrapper/horizontal-checkbox-wrapper.component.html
Outdated
Show resolved
Hide resolved
SGrueber
approved these changes
Mar 15, 2023
Azure Demo Servers are available: |
iwiederhold
approved these changes
Mar 15, 2023
schadii
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[X] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
"Active" checkboxes only have labels and more explanation about their purpose is needed.
What Is the New Behavior?
Checkboxes can have an (optional) title now. The title property is used for the active status checkboxes on the Cost Center Management, User Management, and Punchout User Management.
Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
AB#84147