Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title for status checkboxes #1383

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

DilaraGueler
Copy link
Contributor

@DilaraGueler DilaraGueler commented Mar 1, 2023

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[X] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

"Active" checkboxes only have labels and more explanation about their purpose is needed.

What Is the New Behavior?

Checkboxes can have an (optional) title now. The title property is used for the active status checkboxes on the Cost Center Management, User Management, and Punchout User Management.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X] No

Other Information

AB#84147

@DilaraGueler DilaraGueler requested a review from SGrueber March 1, 2023 16:38
@DilaraGueler DilaraGueler self-assigned this Mar 6, 2023
@DilaraGueler DilaraGueler marked this pull request as ready for review March 6, 2023 10:29
@SGrueber SGrueber changed the title chore: title props for checkboxes feat: add title for status checkboxes Mar 6, 2023
@SGrueber SGrueber added the feature New feature or request label Mar 6, 2023
@SGrueber SGrueber added this to the 4.0 milestone Mar 6, 2023
@github-actions
Copy link

Azure Demo Servers are available:

@SGrueber SGrueber requested review from iwiederhold and schadii March 15, 2023 08:14
@SGrueber SGrueber merged commit 9dafd3f into develop Mar 16, 2023
@SGrueber SGrueber deleted the chore/active-checkbox branch March 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants