Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change templateOptions to props using the formly-migrate schematic #1393

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

andreassteinmann
Copy link
Collaborator

@andreassteinmann andreassteinmann commented Mar 23, 2023

PR Type

[x] Bugfix

What Is the Current Behavior?

The form is still using templateOptions but due to the formly update, it has to use props.

What Is the New Behavior?

To replace deprecated formly field properties, the new formly-migrate schematic ng g formly-migrate --project=intershop-pwa was used to update the properties from templateOptions to props.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

AB#84756

@andreassteinmann andreassteinmann self-assigned this Mar 23, 2023
@andreassteinmann andreassteinmann marked this pull request as ready for review March 23, 2023 09:04
@SGrueber SGrueber requested review from SGrueber and removed request for Eisie96 March 24, 2023 08:40
@SGrueber SGrueber added this to the 4.0 milestone Mar 24, 2023
@andreassteinmann andreassteinmann merged commit 17f7b66 into develop Mar 24, 2023
@andreassteinmann andreassteinmann deleted the fix/punchout-formly-use-props branch March 24, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants