Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add items to basket with common shipping method #1419

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Apr 20, 2023

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The default shipping method is assigned to new basket items. But if there are already items in the basket with a different shipping method the basket will be split into multiple buckets and cannot be ordered by the user any more, because currently multiple buckets are not supported by the pwa.

Issue Number: Closes #

What Is the New Behavior?

The basket common shipping method is assigned to new basket items, so basket items will be added to the existing bucket.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Steps to repeat:

  1. Add a product to cart
  2. Start checkout
  3. Go to checkout shipping page and change the shipping method.
  4. Leave the checkout and add another product to cart.
  5. Start checkout and go to review page.
  6. -> An error message occurs:

image

Other Information

AB#85511

@SGrueber SGrueber requested a review from Eisie96 April 20, 2023 10:07
@SGrueber SGrueber self-assigned this Apr 20, 2023
@SGrueber SGrueber added the bug Something isn't working label Apr 20, 2023
@SGrueber SGrueber added this to the 4.1 milestone Apr 20, 2023
@SGrueber SGrueber merged commit 6ee9909 into develop Apr 24, 2023
@SGrueber SGrueber deleted the bugfix/add_items_to_basket_with_shipping_method branch April 24, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants