feat: dynamic storefront configuration #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
feature/dynamic_storefront_configuration
branch
3 times, most recently
from
155414f to
37edfdf
Compare
shauke
added a commit
that referenced
this pull request
May 17, 2023
…ble with CSS custom properties (#1427) * removed 'darken' and 'lighten' * added Bootstrap overrides that are necessary when working with var color values and the '$primary' and '$secondary' SCSS variable are not necessarily fitting colors * changed 'b2c' theme to a configurable theme with CSS custom properties that can be dynamically configured via ICM CMS Configuration component
shauke
added a commit
that referenced
this pull request
May 17, 2023
…ynamic storefront configuration (#1427) * configure application and locale specific logos, styling, features, generic JSON (e.g. service token) * support feature toggle configuration in extra server configuration * file reference configuration parameter mapper documentation + JSON parsing * DOMService rename 'setCssVariable' to 'setCssCustomProperty' * configure additional style definitions or style file reference * optimization to not redo the extra configuration changes on the client side if they were already done in SSR * add a feature toggle for 'extraConfiguration' Co-authored-by: Silke <s.grueber@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
added a commit
that referenced
this pull request
May 17, 2023
* provide example CMS configuration mock data * renamed 'Multiple Themes' guide to 'Themes' guide * feature toggle documentation + migration note
shauke
force-pushed
the
feature/dynamic_storefront_configuration
branch
from
60e33b5 to
5fab401
Compare
shauke
added a commit
that referenced
this pull request
May 22, 2023
…ynamic storefront configuration (#1427) * configure application and locale specific logos, styling, features, generic JSON (e.g. service token) * support feature toggle configuration in extra server configuration * file reference configuration parameter mapper documentation + JSON parsing * DOMService rename 'setCssVariable' to 'setCssCustomProperty' * configure additional style definitions or style file reference * optimization to not redo the extra configuration changes on the client side if they were already done in SSR * add a feature toggle for 'extraConfiguration' Co-authored-by: Silke <s.grueber@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
added a commit
that referenced
this pull request
May 22, 2023
* provide example CMS configuration mock data * renamed 'Multiple Themes' guide to 'Themes' guide * feature toggle documentation + migration note
shauke
force-pushed
the
feature/dynamic_storefront_configuration
branch
from
5fab401 to
1946156
Compare
DDurakISH
previously approved these changes
May 22, 2023
SGrueber
added a commit
that referenced
this pull request
May 31, 2023
…t for dynamic storefront configuration (#1427)
SGrueber
previously approved these changes
May 31, 2023
SGrueber
added a commit
that referenced
this pull request
May 31, 2023
…t for dynamic storefront configuration (#1427)
SGrueber
force-pushed
the
feature/dynamic_storefront_configuration
branch
from
9e09744 to
97ba95d
Compare
SGrueber
previously approved these changes
May 31, 2023
mglatter
force-pushed
the
feature/dynamic_storefront_configuration
branch
from
361311c to
2afc0c0
Compare
* mostly identified by purgeCSS * preparation for making the 'b2c' theme dynamically customizable with CSS custom properties
…ble with CSS custom properties (#1427) * removed 'darken' and 'lighten' * added Bootstrap overrides that are necessary when working with var color values and the '$primary' and '$secondary' SCSS variable are not necessarily fitting colors * changed 'b2c' theme to a configurable theme with CSS custom properties that can be dynamically configured via ICM CMS Configuration component
…ynamic storefront configuration (#1427) * configure application and locale specific logos, styling, features, generic JSON (e.g. service token) * support feature toggle configuration in extra server configuration * file reference configuration parameter mapper documentation + JSON parsing * DOMService rename 'setCssVariable' to 'setCssCustomProperty' * configure additional style definitions or style file reference * optimization to not redo the extra configuration changes on the client side if they were already done in SSR * add a feature toggle for 'extraConfiguration' Co-authored-by: Silke <s.grueber@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
* provide example CMS configuration mock data * renamed 'Multiple Themes' guide to 'Themes' guide * feature toggle documentation + migration note
shauke
force-pushed
the
feature/dynamic_storefront_configuration
branch
from
2afc0c0 to
a60d8f3
Compare
shauke
added a commit
that referenced
this pull request
Jun 1, 2023
…ble with CSS custom properties (#1427) * removed 'darken' and 'lighten' * added Bootstrap overrides that are necessary when working with var color values and the '$primary' and '$secondary' SCSS variable are not necessarily fitting colors * changed 'b2c' theme to a configurable theme with CSS custom properties that can be dynamically configured via ICM CMS Configuration component
shauke
added a commit
that referenced
this pull request
Jun 1, 2023
…ynamic storefront configuration (#1427) * configure application and locale specific logos, styling, features, generic JSON (e.g. service token) * support feature toggle configuration in extra server configuration * file reference configuration parameter mapper documentation + JSON parsing * DOMService rename 'setCssVariable' to 'setCssCustomProperty' * configure additional style definitions or style file reference * optimization to not redo the extra configuration changes on the client side if they were already done in SSR * add a feature toggle for 'extraConfiguration' Co-authored-by: Silke <s.grueber@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
added a commit
that referenced
this pull request
Jun 1, 2023
* provide example CMS configuration mock data * renamed 'Multiple Themes' guide to 'Themes' guide * feature toggle documentation + migration note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
To have several storefronts with different stylings multiple themes are needed that will introduce with growing number build/deployment/development problems.
What Is the New Behavior?
A configurable theme
b2cwas introduced so only one theme is needed to adapt it via ICM CMS to look different for different storefronts.Does this PR Introduce a Breaking Change?
[x] Yes
The two standard themes
b2bandb2cwhere refactored in such a way that theb2ctheme could be changed into a configurable theme that uses CSS custom properties (CSS variables).Since SCSS color calculations do not work with CSS custom properties (they need real values instead of
var(--corporate-primary)), SCSS functions likedarken()andlighten()were removed from the standard Intershop PWA SCSS styling.Existing projects that do not want to use a configurable theme do not need to apply these changes to their custom styling.
Other Information
AB#85814