Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept only required cookies #1430

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

DilaraGueler
Copy link
Contributor

@DilaraGueler DilaraGueler commented May 11, 2023

PR Type

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

On the cookies banner, the "Accept All" and the "Set Preferences" buttons exist. Under "Set Preferences", a user can decide to go with only essential cookies.

What Is the New Behavior?

Besides the "Accept All" and the "Set Preferences" buttons, the "Accept Only Essentials" button was added to the UI to make it easier to proceed with only essential cookies.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X] No

Other Information

AB#86023

@DilaraGueler DilaraGueler self-assigned this May 12, 2023
@DilaraGueler DilaraGueler marked this pull request as ready for review May 12, 2023 06:59
@github-actions
Copy link

Azure Demo Servers are available:

schadii
schadii previously approved these changes May 15, 2023
@shauke shauke dismissed stale reviews from schadii and andreassteinmann via 65c1656 May 22, 2023 07:52
@shauke shauke added this to the 4.1 milestone May 22, 2023
@shauke
Copy link
Collaborator

shauke commented May 22, 2023

@marschmidt89 Please have a look at the documentation changes as well.

@shauke
Copy link
Collaborator

shauke commented May 22, 2023

New cookie banner options
cookie-banner

marschmidt89
marschmidt89 previously approved these changes May 23, 2023
Copy link
Contributor

@marschmidt89 marschmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation and localization reviewed / approved.

DilaraGueler and others added 2 commits May 24, 2023 10:09
…1430)

* updated documentation cookie banner image with 3 options
…ntation

* plus changes after Cookie Consent documentation review
@shauke shauke force-pushed the feature/accept-essential-cookies branch from 59070e3 to 5f88c05 Compare May 24, 2023 08:54
@shauke shauke merged commit 38f3751 into develop May 24, 2023
@shauke shauke deleted the feature/accept-essential-cookies branch May 24, 2023 08:55
shauke pushed a commit that referenced this pull request May 24, 2023
…1430)

* updated documentation cookie banner image with 3 options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants