-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OCI punchout configuration #1431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
added
enhancement
Enhancement to an existing feature
feature
New feature or request
labels
May 17, 2023
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/oci_punchout_configuration_ui
branch
from
May 17, 2023 09:29
38e1ddc
to
dea3bb9
Compare
Azure Demo Servers are available: |
iwiederhold
previously approved these changes
May 17, 2023
schadii
previously approved these changes
May 17, 2023
SGrueber
requested review from
Eisie96 and
marschmidt89
and removed request for
iwiederhold,
marschmidt89,
Eisie96 and
schadii
June 1, 2023 11:08
Azure Demo Servers are available: |
@iwiederhold Yes. I'll do that |
Azure Demo Servers are available: |
THX! |
SGrueber
force-pushed
the
feature/oci_punchout_configuration_ui
branch
from
June 2, 2023 09:45
3b17b40
to
e2c8591
Compare
marschmidt89
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l10n for DE, EN approved, FR will be checked later.
Eisie96
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the New Behavior?
There is a new page to configure the OCI punchout.
Formatters are not translated, this will be fixed in the next ICM version.
There is only a client side validation for mapping from/to values. All other validations are done by the server and the response error is shown as error message.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#86061