fix: reload the application after the pgid changed #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
suggested changes
Jul 14, 2023
Eisie96
suggested changes
Jul 14, 2023
SGrueber
force-pushed
the
fix/reload_after_pgid_change
branch
from
ae10bd4 to
c396fd9
Compare
Eisie96
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
If the user's pgid changes due to data changes in the ICM backoffice, e.g. assigning/unassigning the user to a customer group, promotion etc. the personalized REST calls will fail with a 400 error: Bad Request (The provided matrix parameter "pgid" does not match the authenticated user.) and an error page is shown in most cases.
Issue Number: Closes #
What Is the New Behavior?
There is a new error handler that checks for the error above and if this error occurs the current page is reloaded. The relaod is necessary because a lot of data in the ngrx store might be affected (invalid) and the reload forces to fetch all the data from the ICM server again.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#87744