feat: logging restriction to errors #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
the
nice to have
dhhyi
force-pushed
the
feat/only-error-logging
branch
2 times, most recently
from
4b8dd2c to
c672bff
Compare
dhhyi
force-pushed
the
feat/only-error-logging
branch
from
c672bff to
0e5392b
Compare
shauke
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
[x] Documentation content changes
What Is the Current Behavior?
If I want to do stress testing with PWA deployments to see, when responses turn into errors, I get flooded with logs of successful information.
What Is the New Behavior?
There is a switch
LOG_ALL(still taking naming suggestions) to disable success logging and restrict the log output to errors only.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#88362