Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove query parameter "page" for product detail page routes #1481

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

andreassteinmann
Copy link
Collaborator

@andreassteinmann andreassteinmann commented Aug 15, 2023

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

When "paging" is enabled instead of "endless-scrolling" on product list pages, the query parameter "page" is part of the URL to determine the current page. If a product detail page is opened from a paged product listing page, this query parameter "page" is part of the product detail page URL. If a master product detail page is opened, the parameter "page" is also used for the paging in the master product detail page and the paged page from the product listing page is opened in the master product detail page (e.g. product listing page "3" opens page "3" on the master product detail page).

What Is the New Behavior?

The query parameter "page" is removed from the link to the product detail page.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#88618
#88428

@andreassteinmann andreassteinmann self-assigned this Aug 15, 2023
@shauke shauke added this to the 4.2 milestone Aug 15, 2023
@shauke shauke added the bug Something isn't working label Aug 15, 2023
@shauke shauke merged commit 28ba5f0 into develop Aug 15, 2023
@shauke shauke deleted the fix/product-detail-page-parameter branch August 15, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants