fix: revert irrelevant changes of "wrong ICM is used with errors on SSR" #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ICM throws errors on SSR (#1519)" * reverted: icmBaseURL no longer uses environment.ts fallback in production mode * reverted: make usage of default/fallback configuration in environment.ts configurable for getting state properties * refactored: errors should only contain properties of defined HttpError interface - this is now handled at the error interceptor * kept: do not log an error that can't be stringified, it floods the log with irrelevant information BREAKING CHANGES: No longer a breaking change regarding "No longer falls back to `environment.ts` configured `icmBaseURL` in production mode."
dhhyi
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvent of #1519
BREAKING CHANGES: No longer a breaking change regarding "No longer falls back to
environment.tsconfiguredicmBaseURLin production mode."PR Type
[x] Bugfix
What Is the New Behavior?
The error object properties in the
error.reducer.tsicm-error-mapper.interceptor.tsare reduced to the defined set of the predefined HttpError interface.Unnecessary changes of #1519 are reverted.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#91270