Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: button for clearing basket #1537

Merged
merged 4 commits into from
Dec 21, 2023
Merged

feat: button for clearing basket #1537

merged 4 commits into from
Dec 21, 2023

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Nov 23, 2023

PR Type

[x] Feature

Now, that I have seen it in a couple of customer projects, it is time to also have this in the OOTB solution.

TODO

  • Translations
  • IAD (button position? success toasts? ...)

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#91470

@dhhyi dhhyi added the feature New feature or request label Nov 23, 2023
@dhhyi dhhyi force-pushed the feat/clear-basket-button branch from 0176f97 to 9c570d1 Compare November 23, 2023 15:06
@shauke
Copy link
Collaborator

shauke commented Nov 29, 2023

@IAD/UX What do you think can we integrate this "clear cart" functionality on the cart page in this way or do you want to suggest changes to the interaction or the visual design?

image

Please use the deployed demo servers for testing.

Copy link

Azure Demo Servers are available:

@dhhyi dhhyi removed their assignment Nov 29, 2023
@iwiederhold
Copy link

Maybe the clear button should be not so prominent as the others.
clear_cart_button

@shauke shauke added this to the 5.0 milestone Nov 29, 2023
@schadii
Copy link

schadii commented Nov 30, 2023

Please keep the confirmation modal for the clear button. About the placement of the button, please see the following screenshot:
Clear basket (2)

@shauke shauke force-pushed the feat/clear-basket-button branch from 9c570d1 to afe539b Compare December 12, 2023 20:40
@SGrueber SGrueber self-assigned this Dec 14, 2023
@SGrueber SGrueber force-pushed the feat/clear-basket-button branch from afe539b to 4f148f0 Compare December 14, 2023 17:10
@SGrueber
Copy link
Collaborator

Regarding to this article we should keep the button to delete the items:

Links should never be used to change the state of an application. This means that clicking on a link should not add, change, or delete any data on the screen, So, a delete action should never be a link, nor should a save action.

@SGrueber SGrueber marked this pull request as ready for review December 15, 2023 11:40
SGrueber
SGrueber previously approved these changes Dec 15, 2023
@iwiederhold
Copy link

If we need to add additional, less-visually competitive actions on a page, we use a link-style button. We have exhausted the use of primary and secondary buttons, a link-style button is the way to go.

marschmidt89
marschmidt89 previously approved these changes Dec 18, 2023
Copy link
Contributor

@marschmidt89 marschmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L10N changes approved.

@SGrueber SGrueber dismissed stale reviews from marschmidt89 and themself via a4b4425 December 21, 2023 08:23
@SGrueber SGrueber force-pushed the feat/clear-basket-button branch from c87387f to a4b4425 Compare December 21, 2023 08:23
@shauke shauke merged commit dd5f34f into develop Dec 21, 2023
21 checks passed
@shauke shauke deleted the feat/clear-basket-button branch December 21, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants