Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle relative links in cms content #1543

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Nov 30, 2023

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

When inserting a link with a relative path to a Free Style HTML Component via TinyMCE (Full Mode) in the ICM backoffice, displaying this component in the PWA lead to a wrong absolute path, as the PWA host is set instaead of the ICM base URL.
This works without any issues when inserting images instead of links.

Issue Number: Closes #

What Is the New Behavior?

Relative paths of free style HTML components are handled correctly.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

see also AB#91284

AB#91696

@SGrueber SGrueber requested a review from shauke November 30, 2023 12:40
@SGrueber SGrueber self-assigned this Nov 30, 2023
@SGrueber SGrueber added this to the 5.0 milestone Nov 30, 2023
@shauke shauke merged commit eb03fde into develop Dec 4, 2023
24 checks passed
@shauke shauke deleted the bugfix/relative_cms_links branch December 4, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants