fix: trailing '/' in path results to a wrong multi channel configuration #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
approved these changes
Dec 12, 2023
shauke
added a commit
that referenced
this pull request
Mar 5, 2024
* addresses issues with trailing slashes for MULTI_CHANNEL configurations without 'baseHref' (introduced with #1553) * fix "the rewritten URI has a zero length" error in nginx multi channel handling * prevents canonical links with doubled "/"(slash) between the domain name and the rest of the path
shauke
added a commit
that referenced
this pull request
Mar 6, 2024
…#1566) * addresses issues with trailing slashes for MULTI_CHANNEL configurations without 'baseHref' (introduced with #1553) * fix "the rewritten URI has a zero length" error in nginx multi channel handling * prevents canonical links with doubled "/"(slash) between the domain name and the rest of the path
shauke
added a commit
that referenced
this pull request
Mar 7, 2024
…#1566) * addresses issues with trailing slashes for MULTI_CHANNEL configurations without 'baseHref' (introduced with #1553) * fix "the rewritten URI has a zero length" error in nginx multi channel handling * prevents canonical links with doubled "/"(slash) between the domain name and the rest of the path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
http://localhost:4200/b2c/homecompared to
http://localhost:4200/b2c/home/results in different storefronts even though the result should be the same
This problem is reproducible with the standard PWA with the following multi channel configuration with a docker compose deployed NGING + SSR container:
Using the wrong channel when working with a trailing
/is the actual problem. The used themes configured channel of theenvironment.b2b.tsis used instead of the one configured in the multi channel configuration of the deployment.The problem occurs with any path after adding a trailing
/.What Is the New Behavior?
An additional rewrite rule for NGINX -
rewrite ^(.*)/$ $1;- removes a trailing slash before handling the route to the SSR container.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#92017