Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display dates that don't have a time specification #1582

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Jan 29, 2024

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

  1. Dates formatted by the date pipe are displayed in GMT if no timezone is given. If the user's timezone is GMT+1 and the date doesn't have a time the date of the previous day is shown to the user. You could see this behavior in the cost center order list. The dates differ from the order list dates by one day.

  2. The data types for some data objects are not correct, e.g. the order creation date of the cost center orders are provided as a number array, but they are defined as a number field.

Issue Number: Closes #

What Is the New Behavior?

  1. The dates are shown in the user's current time zone, if no specific time zone is provided to the date pipe.
  2. The wrong date data types have been corrected.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#93286

@SGrueber SGrueber self-assigned this Jan 29, 2024
@SGrueber SGrueber added the bug Something isn't working label Jan 29, 2024
@SGrueber SGrueber added this to the 5.1 milestone Jan 29, 2024
@SGrueber SGrueber requested a review from shauke January 29, 2024 12:15
@shauke shauke merged commit 33ff2fc into develop Jan 31, 2024
4 checks passed
@shauke shauke deleted the bugfix/date_pipe branch January 31, 2024 16:44
shauke pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants