fix: display of duplicated headers for special logins with activated hydration #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hydration * when loggin in with cobrowse or punchout two headers where rendered for a short time * (the simple header of the loading page and the standard header once the user was logged in) * the hydration introduced with Angular 16 introduced this issue * switching from the usage of ngSwitch to ngIf solved the rendering problem
SGrueber
requested changes
Feb 5, 2024
…er for unknown header types
SGrueber
previously approved these changes
Feb 7, 2024
…eader types BREAKING CHANGES: Changed header rendering and introduced header type (see [Migrations / From 5.0 to 5.1](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51) for more details).
shauke
force-pushed
the
bugfix/duplicated_headers_hydration
branch
from
18a42b2 to
9a4faed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
When loggin in with
/cobrowseor/punchouttwo headers are rendered for a short time. The simple header of the loading page and the standard header once the user was logged in. After a second the simple header will disappear and everything looks as expected.This is only visible with Server Side Rendering and the newly introduced hydration of Angular 16 (https://angular.io/guide/hydration).
What Is the New Behavior?
Switching from the usage of
ngSwitchtongIffor selecting the different headers solved the rendering problem for the login header combinations, even though the HTML source code does not look better this way. :(An alternative could have been to disable the hydration for the header.
But this would also mean to loose these improvements for the header.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#93543