Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable hydration HTTP transfer cache #1635

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Apr 20, 2024

PR Type

[X] Application / infrastructure changes

What Is the Current Behavior?

The introduction of SSR hydration with the last Angular Upgrade also activated HTTP Cache transfer which is not desired in all cases. The PWA version before was designed to specifically refetch certain resources when booting up on the client (i.e. CMS and Product Data).

What Is the New Behavior?

HTTP Client Cache is disabled again.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X] No

Other Information

AB#95994

@dhhyi dhhyi added bug Something isn't working regression Something previously working doesn't work anymore labels Apr 20, 2024
@dhhyi dhhyi self-assigned this Apr 20, 2024
@dhhyi dhhyi requested review from SGrueber and shauke April 20, 2024 08:23
@dhhyi dhhyi marked this pull request as ready for review April 20, 2024 08:23
@dhhyi dhhyi removed their assignment Apr 23, 2024
@shauke shauke added this to the 5.2 milestone Apr 26, 2024
@shauke shauke merged commit 0f664eb into develop Apr 26, 2024
24 checks passed
@shauke shauke deleted the fix/disable-http-transfer-cache branch April 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something previously working doesn't work anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants