perf: disable rendering of view contexts by default #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
chore/disable_viewcontexts_by_default
branch
3 times, most recently
from
8fbd4ea to
6c3cf29
Compare
* commented out view context integration in HTML templates * providing an sample import file with the used view contexts for ICM * added documentation
shauke
force-pushed
the
chore/disable_viewcontexts_by_default
branch
from
6c3cf29 to
2aecf99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Other: disabled for better performance
What Is the Current Behavior?
Up till now we render a set of view contexts throughout the PWAs category and product pages. This creates a lot of REST calls and decreases SSR rendering performance in an unnecessary way if this feature is not used.
What Is the New Behavior?
The view context integration is now commented out and no longer active. It needs to be actively enabled where wanted in a customer project or demo system.
Does this PR Introduce a Breaking Change?
[x] No - if view context rendering was not used
Other Information
AB#96291