fix: implement input mask for IBAN and BIC #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/pages/checkout-payment/payment-parameter-form/payment-parameter-form.component.ts
Show resolved
Hide resolved
src/app/pages/checkout-payment/payment-parameter-form/payment-parameter-form.component.ts
Show resolved
Hide resolved
andreassteinmann
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
Currently input masking is used only for budgets and price notifications.
Issue Number: Closes #1645
What Is the New Behavior?
Consistent behavior would be great. Implement input masking also for IBAN and BIC.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
There is currently no solution to use ngbdatepicker, formly and ngx-mask together. We have therefore decided not to use a mask for dates.
AB#96479