fix: suppress the wrong display of Search-No-Results page after a search #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this happened if a query parameter like a filter has been set before
shauke
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
When searching for a search term in the PWA and applying a filter afterwards, a subsequent search leads to a short display of "NO RESULTS FOUND" before the correct search results are returned.
Issue Number: Closes #
What Is the New Behavior?
The "NO RESULTS FOUND" is not shown in this case any more.
##Steps to repeat
Open the PWA storefront and search for a search term (e.g. "PC").
Select a filter (e.g. Color = "Red").
Search for another search term (e.g. "HDMI").
-> "NO RESULTS FOUND" is displayed for a short time before the correct results are returned.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#97249