-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fast checkout payment (e.g. PAYPAL Express) #1682
Conversation
src/app/pages/basket/shopping-basket-payment/shopping-basket-payment.component.ts
Outdated
Show resolved
Hide resolved
src/app/pages/basket/shopping-basket-payment/shopping-basket-payment.component.ts
Outdated
Show resolved
Hide resolved
src/app/pages/basket/shopping-basket-payment/shopping-basket-payment.component.ts
Outdated
Show resolved
Hide resolved
562d4af
to
b0e2e38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks all much better than before 👍
projects/organization-management/src/app/services/users/users.service.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/payment/payment-cost-info/payment-cost-info.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/payment/payment-cost-info/payment-cost-info.component.ts
Outdated
Show resolved
Hide resolved
src/app/pages/basket/shopping-basket-payment/shopping-basket-payment.component.html
Outdated
Show resolved
Hide resolved
src/app/pages/basket/shopping-basket-payment/shopping-basket-payment.component.spec.ts
Show resolved
Hide resolved
Azure Demo Servers are available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a toast error message instead of this inline error message. Please create a new text for this error because the user does not see the payment methods here.
Error message for the cart page: "We're sorry. Your payment was canceled. You can continue with the checkout or use the express checkout."
We decided to show the "or" between checkout and express checkout button, exactly as it is in the Responsive Starter Store. |
3a70297
to
7bfcd68
Compare
…strument creation (#95945)
* move logic to an effect in order to avoid cancelled request
7bfcd68
to
f75e95f
Compare
…ayment information is available
f75e95f
to
8acdce9
Compare
PR Type
[x] Feature
What Is the Current Behavior?
Not possible to apply fast checkout payment methods.
Issue Number: Closes #95945 (ADO)
What Is the New Behavior?
The fast checkout payment functionality is now available on the basket detail page, if the user is logged in or the 'guestCheckout' feature toggle is switched on.
All available fast checkout payment methods will be displayed in the summary slot .
Does this PR Introduce a Breaking Change?
[x] No
Notes for the Changelog
CHANGES THAT REQUIRE MORE RECENT ICM VERSIONS
fast checkout payment (#1682) - ICM 12.0.0 or ICM 7.10.41.3
Other
AB#97352