Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast checkout payment (e.g. PAYPAL Express) #1682

Merged
merged 18 commits into from
Aug 19, 2024

Conversation

skoch-intershop
Copy link
Contributor

@skoch-intershop skoch-intershop commented Jun 12, 2024

PR Type

[x] Feature

What Is the Current Behavior?

Not possible to apply fast checkout payment methods.

Issue Number: Closes #95945 (ADO)

What Is the New Behavior?

The fast checkout payment functionality is now available on the basket detail page, if the user is logged in or the 'guestCheckout' feature toggle is switched on.
All available fast checkout payment methods will be displayed in the summary slot .
image

Does this PR Introduce a Breaking Change?

[x] No

Notes for the Changelog

CHANGES THAT REQUIRE MORE RECENT ICM VERSIONS
fast checkout payment (#1682) - ICM 12.0.0 or ICM 7.10.41.3

Other

AB#97352

@shauke shauke added this to the 5.2 milestone Jun 25, 2024
@shauke shauke added the feature New feature or request label Jun 25, 2024
@skoch-intershop skoch-intershop force-pushed the feat/prototype_paypal_express branch from 562d4af to b0e2e38 Compare July 19, 2024 12:45
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks all much better than before 👍

@SGrueber SGrueber self-requested a review August 1, 2024 15:04
Copy link

github-actions bot commented Aug 5, 2024

Azure Demo Servers are available:

@SGrueber SGrueber requested review from iwiederhold and M-Behr August 5, 2024 07:36
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the space of 16px after the button-group. (B2B+B2C)

image

For a better usability we should insert a space of 1rem between the checkout button and the other ones.
There used to be an "or" there. That was even better.

image

Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paypal_express_error_payment_canceled

Please use a toast error message instead of this inline error message. Please create a new text for this error because the user does not see the payment methods here.

Error message for the cart page: "We're sorry. Your payment was canceled. You can continue with the checkout or use the express checkout."

@M-Behr
Copy link

M-Behr commented Aug 7, 2024

Please remove the space of 16px after the button-group. (B2B+B2C)

image

For a better usability we should insert a space of 1rem between the checkout button and the other ones. There used to be an "or" there. That was even better.

image

We decided to show the "or" between checkout and express checkout button, exactly as it is in the Responsive Starter Store.

@SGrueber SGrueber force-pushed the feat/prototype_paypal_express branch 3 times, most recently from 3a70297 to 7bfcd68 Compare August 13, 2024 12:45
@shauke shauke changed the title feat: implementation of fast checkout payment (e.g. PAYPAL Expess) (#95945) feat: fast checkout payment (e.g. PAYPAL Expess) Aug 14, 2024
@SGrueber SGrueber changed the title feat: fast checkout payment (e.g. PAYPAL Expess) feat: fast checkout payment (e.g. PAYPAL Express) Aug 15, 2024
@shauke shauke force-pushed the feat/prototype_paypal_express branch from 7bfcd68 to f75e95f Compare August 19, 2024 10:48
@shauke shauke force-pushed the feat/prototype_paypal_express branch from f75e95f to 8acdce9 Compare August 19, 2024 12:08
@shauke shauke merged commit fb5a0d6 into develop Aug 19, 2024
14 checks passed
@shauke shauke deleted the feat/prototype_paypal_express branch August 19, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants