Feature: extend logging #1685
Merged
Feature: extend logging #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently we are missing some information in log (host, request_time and upstream_response_length). It`s an extension to PR #1086
What Is the New Behavior?
mainjsonDoes this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
main13.74.138.162 - - [14/Jun/2024:05:29:01 +0000] "GET /punchout.40df832f6c998a38.js HTTP/1.1" 200 3582 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/101.0.4951.54 Safari/537.36" "13.74.138.162" 0.036 "MISS" "uat.example.com" "3582" 0.034json{"date_access": "2024-06-14T05:29:01+00:00","http": { "ident": "", "method": "GET", "referer": "-", "uri": "/punchout.40df832f6c998a38.js", "host": "uat.example.com", "request_id": "ffd64958f52f2ccb03b458725026cba7", "request_length": 506, "request_time": 0.034, "status_code": 200, "useragent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/101.0.4951.54 Safari/537.36", "protocol": "HTTP/1.1", "x_forward_for": "13.74.138.162"},"ingress": { "name": "pwa-example-pwa-main-cache", "namespace": "pwa-example-uat"},"network": { "bytes_written": 3582, "remote_ip": "13.74.138.162"},"upstream": { "name": "pwa-example-uat-pwa-example-uat-pwa-main-cache-4200", "address_list": "10.240.1.147:80", "status_code": "200", "response_time": "0.036", "response_length": "3582", "cache_status":"MISS"}}AB#97423