Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💰 Order Approval | Basic Requisition Management Project #326

Merged
merged 57 commits into from
Dec 17, 2020

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Jul 15, 2020

💰 Order Approval | Basic Requisition Management

The order approval functionality consists of the following parts:

  • basics
  • requisition, approval and budget management in the myAccount section
  • extend the checkout to submit a basket for approval

basics:

  • requisition-management project
  • routing
  • breadcrumbs
  • requisition model (basic version)
  • state management / facade
  • service
  • permission checks
  • unit testing
  • configuration service toggle
  • approve not always working yet (not for others?)
  • breadcrumb for order detail translation key
  • requisition detail with context facade
  • configuration toggle (maybe extra task)

myAccount:

  • Approval/Requisitions List
  • Approval/Requisition Details
  • Approve/Reject a requisition
  • Manage budgets for users

Checkout:

  • Display Approval required link and dialog in the checkout
  • Submit a requisition and display Thank you for your requisition page

Limitations

  • Currently the cost center approval is not supported, i.e. you still cannot order with all of our demo users. Bio Tech users (ckitera, agoro, bassange, dhanssen) are suitable to demonstrate the functionality.
  • Budgets can only be maintained in one currency

Notes

  • direct routing/browser refresh support
  • requisitions state as part of the customer state that would automatically take care of cleaning the store on logout?
  • list REST call for listings, details call only for the selected details view

PR Type

[x] Feature

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@shauke shauke added the feature New feature or request label Jul 15, 2020
@shauke shauke self-assigned this Jul 15, 2020
@shauke shauke changed the title feat: Requisition Management / Order Approval functionality **:moneybag: Order Approval | Basic Requisition Management Project** Jul 15, 2020
@shauke shauke changed the title **:moneybag: Order Approval | Basic Requisition Management Project** 💰 Order Approval | Basic Requisition Management Project Jul 15, 2020
@shauke shauke changed the title 💰 Order Approval | Basic Requisition Management Project 💰 Order Approval | Basic Requisition Management Project Jul 15, 2020
@shauke shauke force-pushed the feature/requisition-management branch 2 times, most recently from eab2431 to ae05e1d Compare July 15, 2020 10:23
@shauke shauke force-pushed the feature/requisition-management branch from ac950e0 to 88bd4d6 Compare July 24, 2020 22:12
@SGrueber SGrueber force-pushed the feature/requisition-management branch 2 times, most recently from 7182bff to e7f9ae5 Compare July 31, 2020 11:35
@shauke shauke force-pushed the feature/requisition-management branch from 9ce9991 to 4814600 Compare August 15, 2020 10:22
@shauke shauke force-pushed the feature/requisition-management branch 4 times, most recently from 34f17e7 to 28aa8e4 Compare August 27, 2020 20:14
@SGrueber SGrueber force-pushed the feature/requisition-management branch from 28aa8e4 to eecb215 Compare October 12, 2020 11:05
@SGrueber SGrueber requested a review from M-Behr October 12, 2020 11:46
@SGrueber SGrueber force-pushed the feature/requisition-management branch from eecb215 to 956d050 Compare October 12, 2020 16:47
@shauke shauke assigned SGrueber and unassigned shauke Oct 13, 2020
@M-Behr M-Behr requested a review from iwiederhold October 15, 2020 08:51
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic functionality works really good. Thanks for the great teamwork! 👍

I found some minor issues:
Requisition Details
Requisition Details:

  • rename heading in Requisition Details
  • remove pending status of last approver => it is needed, when cost center approval is implemented => then this "Approver(s): Conny Kitera (approved), Ralf Ulitzsch (pending)" is possible and then the user should know who has already approved and who has not

Order Details_Anpassungen
Order Details:

  • some little adaptions: Order Number => Order No.; missing badge
  • remove blank characters next to brackets

Order History vs Requisitions
Phone View:

  • ":" is missing after labels
  • differences between order list and requisition/approval lists => order total is displayed in first row/last row (My mistake! Sorry! I thought this did not fit into the first row.); also the spaces between lines are different => Can we unify this? I suggest: Order total in first line (like order history) and smaller spaces between lines (like requisitions and approvals)

ToDo's for later:

  • add amount of rows (items) in other tables, e.g. order history, order templates, quoting, users.
  • redesign budgets in buyer approval

@SGrueber SGrueber force-pushed the feature/requisition-management branch from c1f8342 to f3b5a10 Compare October 16, 2020 10:06
@SGrueber
Copy link
Collaborator

To improve the responsive design of the order list is not part of this story. You can find a card for it in the technical debts project.

@SGrueber SGrueber force-pushed the feature/requisition-management branch from bd9ff81 to 17d475b Compare October 19, 2020 10:57
@shauke shauke force-pushed the feature/requisition-management branch from 5062192 to 8e16fee Compare December 9, 2020 15:04
@shauke shauke force-pushed the feature/requisition-management branch 2 times, most recently from b197877 to 6061da3 Compare December 15, 2020 07:32
@shauke shauke force-pushed the feature/requisition-management branch from 6061da3 to 9ddf65b Compare December 15, 2020 18:07
@shauke shauke force-pushed the feature/requisition-management branch from 3a37ed1 to beb81c7 Compare December 16, 2020 16:19
@shauke shauke merged commit eee665f into develop Dec 17, 2020
@shauke shauke deleted the feature/requisition-management branch December 17, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants