-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💰 Order Approval | Basic Requisition Management Project #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
changed the title
feat: Requisition Management / Order Approval functionality
**:moneybag: Order Approval | Basic Requisition Management Project**
Jul 15, 2020
shauke
changed the title
**:moneybag: Order Approval | Basic Requisition Management Project**
💰 Order Approval | Basic Requisition Management Project
Jul 15, 2020
shauke
changed the title
💰 Order Approval | Basic Requisition Management Project
💰 Order Approval | Basic Requisition Management Project
Jul 15, 2020
shauke
force-pushed
the
feature/requisition-management
branch
2 times, most recently
from
July 15, 2020 10:23
eab2431
to
ae05e1d
Compare
shauke
force-pushed
the
feature/requisition-management
branch
from
July 24, 2020 22:12
ac950e0
to
88bd4d6
Compare
SGrueber
force-pushed
the
feature/requisition-management
branch
2 times, most recently
from
July 31, 2020 11:35
7182bff
to
e7f9ae5
Compare
shauke
force-pushed
the
feature/requisition-management
branch
from
August 15, 2020 10:22
9ce9991
to
4814600
Compare
shauke
force-pushed
the
feature/requisition-management
branch
4 times, most recently
from
August 27, 2020 20:14
34f17e7
to
28aa8e4
Compare
SGrueber
force-pushed
the
feature/requisition-management
branch
from
October 12, 2020 11:05
28aa8e4
to
eecb215
Compare
SGrueber
force-pushed
the
feature/requisition-management
branch
from
October 12, 2020 16:47
eecb215
to
956d050
Compare
iwiederhold
requested changes
Oct 15, 2020
...isition-management/src/app/components/requisition-summary/requisition-summary.component.html
Show resolved
Hide resolved
M-Behr
requested changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The basic functionality works really good. Thanks for the great teamwork! 👍
I found some minor issues:
Requisition Details:
- rename heading in Requisition Details
- remove pending status of last approver => it is needed, when cost center approval is implemented => then this "Approver(s): Conny Kitera (approved), Ralf Ulitzsch (pending)" is possible and then the user should know who has already approved and who has not
- some little adaptions: Order Number => Order No.; missing badge
- remove blank characters next to brackets
- ":" is missing after labels
- differences between order list and requisition/approval lists => order total is displayed in first row/last row (My mistake! Sorry! I thought this did not fit into the first row.); also the spaces between lines are different => Can we unify this? I suggest: Order total in first line (like order history) and smaller spaces between lines (like requisitions and approvals)
ToDo's for later:
- add amount of rows (items) in other tables, e.g. order history, order templates, quoting, users.
- redesign budgets in buyer approval
SGrueber
force-pushed
the
feature/requisition-management
branch
from
October 16, 2020 10:06
c1f8342
to
f3b5a10
Compare
To improve the responsive design of the order list is not part of this story. You can find a card for it in the technical debts project. |
SGrueber
force-pushed
the
feature/requisition-management
branch
from
October 19, 2020 10:57
bd9ff81
to
17d475b
Compare
shauke
force-pushed
the
feature/requisition-management
branch
from
December 9, 2020 15:04
5062192
to
8e16fee
Compare
shauke
force-pushed
the
feature/requisition-management
branch
2 times, most recently
from
December 15, 2020 07:32
b197877
to
6061da3
Compare
shauke
force-pushed
the
feature/requisition-management
branch
from
December 15, 2020 18:07
6061da3
to
9ddf65b
Compare
shauke
force-pushed
the
feature/requisition-management
branch
from
December 16, 2020 16:19
3a37ed1
to
beb81c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Order Approval | Basic Requisition Management
The order approval functionality consists of the following parts:
basics:
requisition-management
projectmyAccount:
Checkout:
Limitations
Notes
PR Type
[x] Feature
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information