Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: quoting #367

Merged
merged 74 commits into from
Sep 28, 2020
Merged

refactor: quoting #367

merged 74 commits into from
Sep 28, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Aug 26, 2020

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the New Behavior?

Quoting feature is reworked to match new standard.

Does this PR Introduce a Breaking Change?

[x] Yes
[ ] No

TODO:

  • introduce model merging Quote and QuoteRequest REST APIs
  • introduce mapper to map different API responses
  • introduce state management for changed model
  • select/create/get current active QuoteRequest
  • migrate quote list component
  • migrate quote detail component
    • add quote request to basket
    • reject quote
    • create quote request from quote
  • migrate quote request edit component
    • update quote request (name/description/items)
    • submit quote request
  • migrate add product to quote request component
  • migrate create quote request from basket component
  • migrate my account quote widget component
  • migrate quote request edit dialog component, attach to route instead of lazy component
  • breadcrumbs in my account
  • prevent navigating away when edit component has changes
  • success messages as toasts
  • close edit dialog when link on dialog is clicked
  • message on login dialog when trying to add product to quote
  • cleanup & testing
  • re-design e2e tests
  • force inline errors on edit quote request dialog, depends on feat: styled toast messages for success and error messages #356
  • toast messages (see https://jira.intershop.de/browse/ISREST-986)
    • save
    • delete
  • add to basket: deactivated for anonymous users (when logging in baskets will probably get merged and this can lead to undesired effects)
  • https://jira.intershop.de/browse/ISREST-1030 My Account Navigation - Quotes has incorrect placement
  • https://jira.intershop.de/browse/ISREST-938 Quoting - Login Modal - Action is not executed after login
  • https://jira.intershop.de/browse/ISREST-939 Quote Request Details Modal - Rename "Back to Quotes" link
  • https://jira.intershop.de/browse/ISREST-871 Rework Quote/Quote Request handling in the PWA to be more performant
  • https://jira.intershop.de/browse/ISREST-949 Responded quote request - Labels for suggested total are missing in phone view
  • add product to quote request triggered twice in mobile view (when starting workflow logged out)
  • inconsistent save behavior on quote edit page: currently line items are instantly saved when modified, description/name require explicit click on save button:
    • New 1 (chosen): save quote details AND line items only when save is clicked + prevent navigating away via alert/dialog ("You have unsaved changes. Leave page? - Yes/No")
    • New 2: instantly save modifications for all fields, no more save button required.
    • New 3 (chosen): inline edit for name/comment. No more save button required.
  • trigger basket calculation after add quote to basket

Open Questions / TODOs for further improvements:

  • old implementation had a quote state "Converted", but I see no way of detecting if a quote was already used in shopping
  • what is the active quote request, that products are added to?
    • currently we always re-fetch server list and choose the last quote request
    • actions like basket to quote request and quote request from quote/quote request create new (active) quote regardless of previous active quote
  • quote-list paging? (paginated like RSS, endless scrolling)
  • empty quote request page if no items are in quote request?
  • prevent adding quote to basket if already in basket?
    • we could detect this by checking the current basket and deactivating the button
    • currently when adding a quote twice to the basket, an error message is displayed - which is also okay
  • display Quoting groups in basket: https://jira.intershop.de/browse/ISREST-975

REST API TODO:

@dhhyi dhhyi added the refactoring Refactoring of current code label Aug 26, 2020
@dhhyi dhhyi self-assigned this Aug 26, 2020
@dhhyi dhhyi force-pushed the refactor/quoting branch 6 times, most recently from a3336e4 to d559480 Compare September 3, 2020 15:15
@dhhyi dhhyi force-pushed the refactor/quoting branch 8 times, most recently from 49b4a54 to 2212ff6 Compare September 10, 2020 10:11
@dhhyi dhhyi requested a review from M-Behr September 18, 2020 20:42
@dhhyi dhhyi force-pushed the refactor/quoting branch 11 times, most recently from 2eee1aa to 38ae9f7 Compare September 22, 2020 15:57
@dhhyi dhhyi requested a review from shauke September 23, 2020 17:22
@dhhyi dhhyi marked this pull request as ready for review September 23, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants