-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: quoting #367
Merged
Merged
refactor: quoting #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/quoting
branch
6 times, most recently
from
September 3, 2020 15:15
a3336e4
to
d559480
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
8 times, most recently
from
September 10, 2020 10:11
49b4a54
to
2212ff6
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
from
September 13, 2020 09:02
9961ecc
to
7f3d820
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
11 times, most recently
from
September 22, 2020 15:57
2eee1aa
to
38ae9f7
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
from
September 23, 2020 17:18
87b4f88
to
533ea7b
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
from
September 23, 2020 21:11
4ea4cff
to
73bbbd8
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
from
September 25, 2020 13:58
2dc55c1
to
8b8fde9
Compare
dhhyi
force-pushed
the
refactor/quoting
branch
from
September 25, 2020 14:55
7d7df05
to
877aa9a
Compare
shauke
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the New Behavior?
Quoting feature is reworked to match new standard.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
TODO:
(chosen): save quote details AND line items only when save is clicked + prevent navigating away via alert/dialog ("You have unsaved changes. Leave page? - Yes/No")Open Questions / TODOs for further improvements:
REST API TODO:
quoterequests
should include table data (like quotes resource via attrs). At leastcreationDate
for sorting/paging -> https://jira.intershop.de/browse/IS-30986quoterequests
API responds with redirect if quote request has become a quote in the meantime -> https://jira.intershop.de/browse/IS-31003quotes
is missing rejected flag -> https://jira.intershop.de/browse/IS-31004