Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tacton improvements #368

Merged
merged 9 commits into from
Aug 27, 2020
Merged

fix: tacton improvements #368

merged 9 commits into from
Aug 27, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Aug 26, 2020

PR Type

[x] Bugfix

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

TODO:

  • remove compare, price, availability, shipping, ... of configurable products
  • change success message after submit to sth like "Your quote request has been submitted. We will e-mail pmiller@test.intershop.de to keep you updated on the status of your quote request." - used checkout.receipt.notification.mail.text as template
  • highlight sublevel in navigation on scrolling
  • click on image-text-button's image should trigger change
  • Yes/No buttons with https://getbootstrap.com/docs/4.5/components/buttons/#checkbox-and-radio-buttons
  • rename Submit button to "Request Firm Proposal"
  • Action Bar breakpoint at 992px messed up. Maybe display buttons as blocks?
  • BOM: No. => Product ID if possible.

Demo Server: http://pwa-gh-review-368-universal-b2b.azurewebsites.net/home;features=compare,recently,advancedVariationHandling,businessCustomerRegistration,quoting,quickorder,orderTemplates,tacton

@dhhyi dhhyi self-assigned this Aug 26, 2020
@dhhyi dhhyi added enhancement Enhancement to an existing feature refactoring Refactoring of current code labels Aug 26, 2020
@dhhyi dhhyi added this to the 0.23 milestone Aug 26, 2020
@dhhyi dhhyi force-pushed the fix/tacton-improvements branch from 07be5f3 to e07fb06 Compare August 26, 2020 17:39
@dhhyi dhhyi force-pushed the fix/tacton-improvements branch from e07fb06 to 831f9f5 Compare August 26, 2020 18:02
@dhhyi dhhyi marked this pull request as ready for review August 26, 2020 18:32
@dhhyi dhhyi requested review from M-Behr, shauke and suschneider August 26, 2020 23:09
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :) Thanks a lot for the improvements.

@dhhyi dhhyi merged commit 84ed633 into develop Aug 27, 2020
@dhhyi dhhyi deleted the fix/tacton-improvements branch August 27, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants