Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display payment costs according to the configured display type (… #396

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 1, 2020

…gross/net)

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

On the checkout payment page the payment costs are always shown as net prices in the payment selection widget.

Issue Number: Closes #

What Is the New Behavior?

The payment costs are shown according to the price display type (gross/net). The price display type can be configured in the ICM back office.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber self-assigned this Oct 1, 2020
@SGrueber SGrueber added the bug Something isn't working label Oct 1, 2020
@SGrueber SGrueber added this to the 0.25 milestone Oct 1, 2020
Copy link
Collaborator

@dhhyi dhhyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SGrueber SGrueber merged commit b89c59d into develop Oct 6, 2020
@SGrueber SGrueber deleted the bugfix/display_payment_cost branch October 6, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants