Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set breadcrumb from routing only if none was set previously #402

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Oct 5, 2020

Closes #399

PR Type

[x] Bugfix

What Is the Current Behavior?

introduced by 3e55b63

What Is the New Behavior?

Fixed.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

TODO:

  • extend e2e tests for quoting, order-templates, wishlists and orders to check breadcrumb for list vs. detail pages.

@dhhyi dhhyi added the bug Something isn't working label Oct 5, 2020
@dhhyi dhhyi added this to the 0.25 milestone Oct 5, 2020
@dhhyi dhhyi requested a review from SGrueber October 5, 2020 17:44
@dhhyi dhhyi self-assigned this Oct 5, 2020
SGrueber
SGrueber previously approved these changes Oct 7, 2020
SGrueber
SGrueber previously approved these changes Oct 8, 2020
@SGrueber SGrueber force-pushed the fix/breadcrumb-for-details branch from 3e03959 to 5ab3660 Compare October 8, 2020 09:10
SGrueber
SGrueber previously approved these changes Oct 8, 2020
SGrueber
SGrueber previously approved these changes Oct 8, 2020
@dhhyi dhhyi force-pushed the fix/breadcrumb-for-details branch from 19bb994 to bfe7e70 Compare October 8, 2020 10:42
@dhhyi dhhyi merged commit 530ba90 into develop Oct 8, 2020
@dhhyi dhhyi deleted the fix/breadcrumb-for-details branch October 8, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong breadcrumb on many detail myAccount pages
2 participants