Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): lazy-components for projects #437

Merged
merged 11 commits into from
Nov 16, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Oct 23, 2020

PR Type

[x] Feature

What Is the Current Behavior?

lazy-component schematic works only for extensions.

What Is the New Behavior?

lazy-component schematic also works for projects.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

TODO:

  • adapt schematic
  • add test for project
  • create exports module if it does not exist
  • export lazy component in index.ts for tests?
  • adapt tslint rules

@dhhyi dhhyi added the enhancement Enhancement to an existing feature label Oct 23, 2020
@dhhyi dhhyi self-assigned this Oct 23, 2020
@dhhyi dhhyi force-pushed the feature/lazy-components-in-projects branch from 3466f6c to 0ee3c3c Compare October 23, 2020 10:16
@MaxKless MaxKless self-assigned this Nov 10, 2020
@MaxKless MaxKless marked this pull request as ready for review November 13, 2020 13:38
schematics/src/utils/registration.ts Outdated Show resolved Hide resolved
schematics/src/utils/registration.ts Outdated Show resolved Hide resolved
schematics/src/lazy-component/factory.ts Show resolved Hide resolved
schematics/src/lazy-component/factory.ts Show resolved Hide resolved
@MaxKless MaxKless merged commit 18a3f2f into develop Nov 16, 2020
@MaxKless MaxKless deleted the feature/lazy-components-in-projects branch November 16, 2020 15:38
@shauke shauke added this to the 0.26 milestone Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants