perf: deny SSR rendering when accept headers do not match #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
perf/ssr-shortcut-for-accept-mismatch
branch
from
1d9f18d to
2a0efe9
Compare
MaxKless
previously approved these changes
Nov 23, 2020
MaxKless
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Other: Performance Improvement
What Is the Current Behavior?
Requests for static resources, that don't exist, trigger an SSR rendering cycle which renders the error page.
What Is the New Behavior?
The request accept headers are used to determine if the browser was expecting an html response. If the static resource was referenced in an img src, link or script tag, the browser doesn't explicitly request html content. This can be used to short-cut the 404 response and not trigger SSR.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Accept