Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-channel with multi ICM support #536

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Feb 6, 2021

PR Type

[x] Feature

What Is the Current Behavior?

Issue Number: Closes #420

What Is the New Behavior?

Multi-Channel support is also multi-ICM support 🎉

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added the enhancement Enhancement to an existing feature label Feb 6, 2021
@dhhyi dhhyi added this to the 0.28 milestone Feb 6, 2021
@dhhyi dhhyi self-assigned this Feb 6, 2021
@dhhyi dhhyi force-pushed the feature/multi-channel-icms branch from 20d57b8 to 6089999 Compare February 7, 2021 21:47
@jometzner jometzner self-assigned this Feb 12, 2021
@shauke shauke removed their request for review February 17, 2021 10:26
jometzner
jometzner previously approved these changes Feb 19, 2021
Copy link
Collaborator

@jometzner jometzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with gomplate locally. It suits the need. Even though I'm more a fan of using the tools the image already provides.

Thanks Dan.

@dhhyi dhhyi force-pushed the feature/multi-channel-icms branch from 6089999 to 11e3d57 Compare February 19, 2021 09:29
@jometzner jometzner removed their assignment Feb 19, 2021
@dhhyi dhhyi merged commit 434ed47 into develop Feb 19, 2021
@dhhyi dhhyi deleted the feature/multi-channel-icms branch February 19, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple ICM systems with one PWA
2 participants