refactor: use native swiper instead of ngx-swiper-wrapper #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
requested changes
Feb 17, 2021
There was a problem hiding this comment.
Before
After
The controls for click slide switching are missing. Swiping with mouse drag & drop works though (meaning the Swiper is initialized).
The same is with the product links (see "You may also like")
Before
https://intershoppwa.azurewebsites.net/Smart-Home/Google-Home-sku201807171-catHome-Entertainment.SmartHome
After
http://pwa-gh-review-552-universal-b2c.azurewebsites.net/Smart-Home/Google-Home-sku201807171-catHome-Entertainment.SmartHome
dhhyi
force-pushed
the
refactor/use-native-swiper
branch
2 times, most recently
from
a2b507f to
c37f9d6
Compare
suschneider
force-pushed
the
refactor/use-native-swiper
branch
2 times, most recently
from
38e81b8 to
b219546
Compare
suschneider
previously approved these changes
Feb 24, 2021
shauke
force-pushed
the
refactor/use-native-swiper
branch
from
b219546 to
fbdb789
Compare
shauke
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
ngx-swiper-wrapper is used in the PWA but it will not be supported any longer (see migration note for link).
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information