Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: b2b sso #597

Merged
merged 47 commits into from
Mar 26, 2021
Merged

feat: b2b sso #597

merged 47 commits into from
Mar 26, 2021

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Mar 4, 2021 •
edited
Loading

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the New Behavior?

SSO with Auth0 works for B2B

ToDo

  • check whether login works in checkout
  • disable provided information?
  • cancel registration doesn't work / reset state
  • general solution to be able to fill everything
  • decide on final registrationConfigurationService placement
  • Create tests for auth0.identity-provider.ts
  • get "Personal Information" and "Complete your Account" translation
  • Integrate B2C registration into B2B observable stream
  • Write missing jest tests
  • Fix redirect after successful registration
  • prefill information and disable it
  • Register Link is not working currently. Please fix (trigger register)
  • clean up registration component override in test (chaining off of compileComponents)

Does this PR Introduce a Breaking Change?

[ ] Yes
[ ] No

Other Information

@MaxKless MaxKless added the feature New feature or request label Mar 4, 2021
@MaxKless MaxKless changed the title feat: add registration config service feat: b2b sso Mar 4, 2021
@MaxKless MaxKless added this to the 0.29 milestone Mar 22, 2021
@MaxKless MaxKless force-pushed the feature/b2b-sso branch 2 times, most recently from 3177f15 to 76802f1 Compare March 24, 2021 12:00
MaxKless and others added 18 commits March 24, 2021 14:55
@MaxKless MaxKless requested review from shauke and suschneider March 25, 2021 18:14
suschneider
suschneider approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@suschneider suschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review done

@MaxKless MaxKless marked this pull request as ready for review March 26, 2021 14:23
@MaxKless MaxKless merged commit 49a93a8 into develop Mar 26, 2021
@MaxKless MaxKless deleted the feature/b2b-sso branch March 26, 2021 14:36
shauke pushed a commit that referenced this pull request Mar 26, 2021
@MaxKless @jometzner
@marschmidt89 @shauke
feat: SSO with Auth0 for B2B (#597)
b8ada93 
BREAKING CHANGE: registration form configuration via a new registration configuration service

Co-authored-by: Johannes Metzner <jm@jometzner.de>
Co-authored-by: Marcus Schmidt <marcus.schmidt@intershop.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suschneider suschneider suschneider approved these changes

@shauke shauke Awaiting requested review from shauke

Assignees

@jometzner jometzner

@MaxKless MaxKless

Labels
feature New feature or request
Projects
None yet
Milestone
0.29
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxKless @suschneider @jometzner @marschmidt89