Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt purgecss configuration to prevent purging needed styles #601

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 5, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

  • toast styles are removed by PurgeCSS

Issue Number: Closes #600

What Is the New Behavior?

  • toast styles are kept

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

relates to #562

@dhhyi dhhyi added the bug Something isn't working label Mar 5, 2021
@dhhyi dhhyi requested a review from M-Behr March 5, 2021 19:06
@shauke shauke self-assigned this Mar 8, 2021
@shauke shauke added this to the 0.29 milestone Mar 8, 2021
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is not completely fixed yet. The error toast hast still styling issues.

Current state:
image

The way it was and should be:
image

@shauke shauke assigned suschneider and unassigned shauke Mar 8, 2021
@shauke
Copy link
Collaborator

shauke commented Mar 8, 2021

image

This could be another missing styling after purgecss issue.

@M-Behr
Copy link

M-Behr commented Mar 8, 2021

The tabs in the My Account section are also affected. Please take a look at this as well. Maybe it has the same cause.
screenshot-intershoppwa-b2b azurewebsites net-2021 03 08-17_10_02

@shauke shauke changed the title fix: prevent toast styles purging fix: adapt purgecss configuration to prevent purging needed styles Mar 9, 2021
@suschneider suschneider requested a review from shauke March 18, 2021 16:27
@suschneider suschneider merged commit 87a3135 into develop Mar 19, 2021
@suschneider suschneider deleted the fix/toast-styling branch March 19, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast Messages: Styles are not displayed
4 participants