fix: multi site not working language switch #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The whole issue happens only when using multi site configuration based on path switch (not tld based). .+\.de:
- baseHref: /b2c
lang: en_US
channel: inSPIRED-inTRONICS-Site
- baseHref: /b2b
lang: en_US
channel: inSPIRED-inTRONICS_Business-Site
features: quoting,businessCustomerRegistration,advancedVariationHandling,quickorder,orderTemplates,punchout,wishlists
theme: "blue|688dc3" |
jometzner
force-pushed
the
fix/multi-site-language-switch
branch
from
56601c4 to
ad441c2
Compare
shauke
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Language switch component links to different URL and not multi site URL location that fits to the current page.
What Is the New Behavior?
Language switch component links to same URL location that denotes the current page.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information