Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cms carousel component should handle not completely filled slides #663

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented Apr 19, 2021

PR Type

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

It is not possible to display not fully completed slides in cms-carousel-component.

Issue Number: Closes #450

What Is the New Behavior?

Not fully completed slides are displayed in cms-carousel-component.

Does this PR Introduce a Breaking Change?

[ ] Yes
[ x] No

Other Information

@shauke shauke marked this pull request as ready for review April 19, 2021 15:10
@shauke shauke self-requested a review April 19, 2021 15:31
@shauke shauke added the bug Something isn't working label Apr 19, 2021
@shauke shauke added this to the 0.30 milestone Apr 19, 2021
@shauke shauke merged commit baff0c4 into develop Apr 19, 2021
@shauke shauke deleted the bugfix/cms-carousel-component-calculation branch April 19, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS Carousel Component slide items calculation failure
2 participants