feat: Allow Intershop CMS Freestyle HTML component links to sub-categories #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
In a Freestyle HTML CMS component if you create a link to any sub-category (level 2 or higher) you will get a page not found error when rendering the resulting markup.
This is because links like this
category://categoryid@catalog-domainare translated to simple category routes not following ouruniqueCategoryIdscheme. For instance above category link is translated to '/catcategoryid`.What Is the New Behavior?
category://x@ylinks are now translated into a new category page route called/categoryref/:categoryRefId. The category page component is left untouched by this. Resulting in canonical URLs no matter how you reached a particular category detail page.Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
Only compatible with ICM version 7.10.17 or higher