Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for CMS "Product Lists (Category)" and "Product List (Filter)" + "Product List" improvements #673

Merged
merged 7 commits into from
Jun 10, 2021
Merged

feat: support for CMS "Product Lists (Category)" and "Product List (Filter)" + "Product List" improvements #673

merged 7 commits into from
Jun 10, 2021

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Apr 26, 2021 •
edited by Eisie96
Loading

PR Type

[x] Feature
[x] Other: improvements for "Product List"

What Is the Current Behavior?

The Intershop PWA currently supports only manually managed product lists as CMS component without the option to display this list as carousel.

Issue Number: Closes #285

What Is the New Behavior?

Added support for the CMS components "Product Lists (Category)" - displays a configurable amount of products of the selected category - and "Product List (Filter)" - displays a configurable amount of products of the selected search engine filter.
Improvements for the Product List components to allow for a carousel rendering.

Does this PR Introduce a Breaking Change?

[x] No

Todo:

Product Lists (Category)

  • fetch the product skus for the configured category (with consideration of MaxNumberOfProducts)
  • implement rendering component
  • support ShowViewAll link

Product List (Filter)

  • fetch the product skus for the configured filter (with consideration of MaxNumberOfProducts)
  • implement rendering component
  • support "Scope" (GlobalScope vs. CurrentCategoryScope)?

general product list improvements

  • carousel support (based on swiper, see ProductLinksCarouselComponent)
  • implement "List Item Style" configuration for "Tile" or "Row" rendering
  • support responsive design for carousel products listings
  • swiper slide items not initializing correctly

ICM

  • "Product Lists (Category)" pagelet definition in app_sf_base_cm
  • "Product Lists (Filter)" pagelet definition in app_sf_base_cm

@shauke shauke added the feature New feature or request label Apr 26, 2021
@shauke shauke added this to the 0.30 milestone Apr 26, 2021
@shauke shauke modified the milestones: 0.30, 0.31 Apr 27, 2021
@Eisie96 Eisie96 force-pushed the feature/cms_product_lists branch from eacde13 to dff1425 Compare April 30, 2021 11:08
@shauke shauke self-assigned this May 7, 2021
@shauke shauke marked this pull request as ready for review May 11, 2021 08:39
@Eisie96 Eisie96 assigned shauke and unassigned shauke May 11, 2021
@shauke shauke force-pushed the feature/cms_product_lists branch from 78867b1 to 7ef4a70 Compare May 18, 2021 16:09
shauke
shauke commented May 19, 2021
View reviewed changes
Copy link
Collaborator Author

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple Carousels/sliders not working independently.
Slider not working right with manual product list.
Slider paging buttons not positioned centered and at each slider.

src/app/shared/cms/components/content-product-list/content-product-list.component.ts Outdated Show resolved Hide resolved
...app/shared/cms/components/cms-product-list-category/cms-product-list-category.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.ts Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
src/app/shared/cms/components/content-product-list/content-product-list.component.html Outdated Show resolved Hide resolved
@shauke shauke force-pushed the feature/cms_product_lists branch 2 times, most recently from 9d0ae65 to b5bd7d7 Compare May 28, 2021 16:50
@shauke shauke modified the milestones: 0.31, 0.32 Jun 1, 2021
@shauke shauke force-pushed the feature/cms_product_lists branch from 28a102f to 508c001 Compare June 3, 2021 06:09
@shauke shauke force-pushed the feature/cms_product_lists branch from 082c03a to 0fe2efd Compare June 10, 2021 15:00
@shauke shauke merged commit 6edf125 into develop Jun 10, 2021
@shauke shauke deleted the feature/cms_product_lists branch June 10, 2021 15:45
shauke added a commit that referenced this pull request Jun 10, 2021
@shauke
feat: introduce content parameter state management - initial with fil…
6aa7fb4 
…tered product lists (#673)
shauke pushed a commit that referenced this pull request Jun 10, 2021
@Eisie96 @shauke
feat: introduce shared ProductsList component with list and carousel …
8df9599 
…view (#673)
shauke pushed a commit that referenced this pull request Jun 10, 2021
@Eisie96 @shauke
feat: add support for CMS component "Product List (Filter)" (#673)
fbc5e3e
shauke pushed a commit that referenced this pull request Jun 10, 2021
@Eisie96 @shauke
feat: add support for CMS component "Product List (Category)" (#673)
d3f0489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eisie96 Eisie96 Eisie96 left review comments

Assignees

@Eisie96 Eisie96

@shauke shauke

Labels
feature New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Filtered Products List CMS Component
2 participants
@shauke @Eisie96