Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair data refresh on product pages #675

Merged
merged 1 commit into from
May 3, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented May 1, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

Data is not properly refreshed while switching between product detail pages once a product master or retail set is chosen.

Steps:

  • open browser development tools, network tab, filter for products/
  • go to master product: https://intershoppwa-b2b.azurewebsites.net/sku201807231
  • switch to first variation (product call is being made)
  • switch back to master via "Choose Another Variation"
    -> no call is made to refresh the master product data

What Is the New Behavior?

Level true (which means always refetch (set in SelectedProductContextFacade)) is not being overridden in postProductFetch of ProductContextFacade.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added the bug Something isn't working label May 1, 2021
@dhhyi dhhyi requested a review from shauke May 1, 2021 22:40
@shauke shauke self-assigned this May 3, 2021
@shauke shauke added this to the 0.30 milestone May 3, 2021
@shauke shauke merged commit 8eaac04 into develop May 3, 2021
@shauke shauke deleted the fix/refresh-product-for-pdp branch May 3, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants