fix: track item changes as local state in checkout facade #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
commented
May 17, 2021
| whenTruthy(), | ||
| distinctUntilChanged(), | ||
| switchMap(() => this.basketLoading$.pipe(debounceTime(500), whenFalsy())), | ||
| shareReplay(1) |
There was a problem hiding this comment.
shareReplay is not a solution here, because the header is re-initialized via AppFacade.headerType$ when leaving the checkout. We need a "global" Observable that only emits when new changes happen. Using only NgRx is also not a good solution as all subscriptions emit the last value and working with skip(1) on subscribe is masking quite a lot (also not working btw). The only probable solution might really be local state in the facade...
Eisie96
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
Issue Number: Closes #668
What Is the New Behavior?
fixed 😁👍
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No