feat: language switch with multisite support #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
changed the title
shauke
force-pushed
the
feat/language-switch-multisite
branch
from
f0c1329 to
27741e9
Compare
shauke
requested changes
Jun 17, 2021
There was a problem hiding this comment.
The generated links in the language switch component look like this now for our standard multi-site configuration: http://localhost:4200/de/home;redirect=1;lang=de_DE
I would have expected http://localhost:4200/de/home. What is the reason for keeping the ;redirect=1;lang=de_DE part. Isn't this still doing things that would no longer be necessary?
This comment has been minimized.
This comment has been minimized.
shauke
force-pushed
the
feat/language-switch-multisite
branch
from
27741e9 to
223e097
Compare
dhhyi
reviewed
Jun 20, 2021
dhhyi
previously requested changes
Jun 20, 2021
There was a problem hiding this comment.
I think the multiSiteLocaleMap must not only be a environment.ts property, but an environment property. It should also be possible to define complete URLs to switch to so that this feature also works when the multi-site setup is using different domains for each channel.
MaxKless
force-pushed
the
feat/language-switch-multisite
branch
from
223e097 to
628f24e
Compare
shauke
requested changes
Jun 24, 2021
src/app/shell/header/language-switch/language-switch.component.html
Outdated
Show resolved
Hide resolved
…ommented example (this combination is not yet working)
shauke
requested changes
Jun 30, 2021
shauke
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently, the language switch only changes the language and completely ignores any multisite config.
What Is the New Behavior?
Now the language switch works with our new default multi site setup and can be configured/overridden to work with arbitrary multi site configurations.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x No
Other Information