Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double-check missing translation before reporting #728

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jun 15, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

Issue Number: Closes #726

What Is the New Behavior?

Fixed

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi self-assigned this Jun 15, 2021
@dhhyi dhhyi added the bug Something isn't working label Jun 15, 2021
@dhhyi dhhyi requested a review from MaxKless June 15, 2021 09:54
@dhhyi dhhyi marked this pull request as ready for review June 15, 2021 09:54
@MaxKless MaxKless merged commit f1eb525 into develop Jun 15, 2021
@MaxKless MaxKless deleted the fix/double-check-missing-translation branch June 15, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translation triggers error for both actual and fallback language
2 participants