Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display edit line item link only for variation products #741

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

SGrueber
Copy link
Collaborator

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If the feature toggle 'advancedVariationhandling' is turned off the edit link is shown for all products in the cart.

What Is the New Behavior?

If the feature toggle 'advancedVariationhandling' is turned off the edit link is shown only for variation products in the cart.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber self-assigned this Jun 21, 2021
@SGrueber SGrueber added this to the 0.32 milestone Jun 21, 2021
@SGrueber SGrueber requested a review from M-Behr June 21, 2021 10:59
M-Behr
M-Behr previously approved these changes Jun 21, 2021
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine 👍

shauke
shauke previously approved these changes Jun 22, 2021
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase might be necessary.

@SGrueber SGrueber dismissed stale reviews from shauke and M-Behr via 225e4bc June 22, 2021 12:17
@SGrueber SGrueber force-pushed the bugfix/edit_basket_line_items branch from ec12e58 to 225e4bc Compare June 22, 2021 12:17
@SGrueber SGrueber force-pushed the bugfix/edit_basket_line_items branch from 225e4bc to 48401b7 Compare June 22, 2021 12:18
@SGrueber SGrueber merged commit 03c9988 into develop Jun 22, 2021
@SGrueber SGrueber deleted the bugfix/edit_basket_line_items branch June 22, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants