fix: adapt project SCSS definitions in regards to sass '/' deprecation warnings #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n warnings - introduced by the the latest @angular-devkit/build-angular update that updates 'sass' from 1.32.12 to 1.35.1 DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div($spacer, 2) More info and automated migrator: https://sass-lang.com/d/slash-div
shauke
force-pushed
the
bugfix/sass_deprecations
branch
from
df9ac2d to
b65daa4
Compare
SGrueber
approved these changes
Jun 29, 2021
shauke
added a commit
that referenced
this pull request
Oct 29, 2021
* remove `@use 'sass:math';` and replace `math.div();` * cleanup after temporary changes from #751 closes: #759 BREAKING CHANGE: We no longer use `@use 'sass:math';` and `math.div();` in our `.scss` files but instead switched to the new Bootstrap default way using `divide()`. This is more a note to check your styling customizations for possible adaptions. Both ways should still work together and adaptions are not required.
shauke
added a commit
that referenced
this pull request
Nov 10, 2021
) * remove `@use 'sass:math';` and replace `math.div();` * cleanup after temporary changes from #751 closes: #759 BREAKING CHANGE: We no longer use `@use 'sass:math';` and `math.div();` in our `.scss` files but instead switched to the new Bootstrap default way using `divide()`. This is more a note to check your styling customizations for possible adaptions. Both ways should still work together and adaptions are not required.
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
) * remove `@use 'sass:math';` and replace `math.div();` * cleanup after temporary changes from #751 closes: #759 BREAKING CHANGE: We no longer use `@use 'sass:math';` and `math.div();` in our `.scss` files but instead switched to the new Bootstrap default way using `divide()`. This is more a note to check your styling customizations for possible adaptions. Both ways should still work together and adaptions are not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Build-related changes
What Is the Current Behavior?
Introduced by the the latest
@angular-devkit/build-angularupdate that updatessassfrom 1.32.12 to 1.35.1 a lot of deprecation warnings where printed when building the project or runningng serve.What Is the New Behavior?
The project SCSS definitions were changed in regards to the sass '/' deprecation warnings.
Only Bootstrap SCSS compile warnings persist that result from the original Bootstrap definitions that cannot be changed in the project itself. Hopefully they will be fixed in the Bootstrap sources (see twbs/bootstrap#34353).
Does this PR Introduce a Breaking Change?
[x] No
Other Information
https://sass-lang.com/documentation/breaking-changes/slash-div
https://github.com/sass/dart-sass/blob/master/CHANGELOG.md#1330
twbs/bootstrap#34353