Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-PWA container build with runtime theme switching #775

Merged
merged 2 commits into from
Aug 3, 2021
Merged

feat: multi-PWA container build with runtime theme switching #775

merged 2 commits into from
Aug 3, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jul 7, 2021 •
edited
Loading

PR Type

[x] Feature
[x] Refactoring (no functional changes, no API changes)
[x] Build-related changes
[x] CI-related changes
[x] Documentation content changes
[x] Application / infrastructure changes

What Is the Current Behavior?

The Intershop PWA only supports building one Angular application in the Docker image and uses runtime theming for switching brands. This way component overrides cannot be used automatically.

What Is the New Behavior?

  • Build and deploy multiple PWA configurations into the Docker image
  • PM2 for process management
  • external stateful Prometheus service instead of stateful SSR process

Does this PR Introduce a Breaking Change?

[x] Yes
[ ] No

Other Information

breaking change notice for squash commit:

  BREAKING CHANGE: build process in docker image was enhanced to enable multiple configurations at runtime.

AB#64624

@dhhyi dhhyi added feature New feature or request refactoring Refactoring of current code research Exploration for fancy new stuff labels Jul 7, 2021
@dhhyi dhhyi self-assigned this Jul 7, 2021
@dhhyi dhhyi mentioned this pull request Jul 9, 2021
Closed
@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build branch 10 times, most recently from a28ebed to 97af2ce Compare July 15, 2021 17:45
@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build branch 3 times, most recently from 9348772 to 5ee9fdf Compare July 19, 2021 10:42
@dhhyi dhhyi marked this pull request as ready for review July 19, 2021 11:42
@dhhyi dhhyi requested a review from shauke July 19, 2021 11:42
shauke
shauke requested changes Jul 19, 2021
View reviewed changes
docs/guides/migrations.md Outdated Show resolved Hide resolved
docs/guides/customizations.md Show resolved Hide resolved
docs/guides/customizations.md Outdated Show resolved Hide resolved
docs/guides/customizations.md Show resolved Hide resolved
@dhhyi dhhyi requested a review from shauke July 20, 2021 08:57
@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build branch from eb75ca2 to eaa5134 Compare July 20, 2021 13:39
dhhyi added a commit that referenced this pull request Jul 22, 2021
@dhhyi
feat: multi-PWA container build with runtime theme switching (#775)
29d4821
@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build branch from eaa5134 to 29d4821 Compare July 22, 2021 11:17
@dhhyi dhhyi changed the base branch from develop to feat/dynamic-deploy-url July 22, 2021 11:17
@dhhyi
Copy link
Collaborator Author

dhhyi commented Jul 22, 2021

@jometzner @shauke I rebased upon #630 due to performance test issue that was caused by #624

@jometzner
Copy link
Collaborator

Thanks. I'm currently deploying that into our INT system. I'll keep you posted

dhhyi added a commit that referenced this pull request Jul 23, 2021
@dhhyi
feat: multi-PWA container build with runtime theme switching (#775)
0045ddd
@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build branch from 29d4821 to 0045ddd Compare July 23, 2021 10:25
jometzner pushed a commit that referenced this pull request Jul 30, 2021
@dhhyi @jometzner
feat: multi-PWA container build with runtime theme switching (#775)
4fd7d8d
@jometzner jometzner force-pushed the refactor/multi-pwa-container-build branch from c70554f to 4fd7d8d Compare July 30, 2021 13:29
@jometzner jometzner force-pushed the develop branch 2 times, most recently from 3256ec2 to 8418166 Compare July 30, 2021 15:06
jometzner pushed a commit that referenced this pull request Jul 30, 2021
@dhhyi @jometzner
feat: multi-PWA container build with runtime theme switching (#775)
5f69504
@jometzner jometzner force-pushed the refactor/multi-pwa-container-build branch from 4fd7d8d to 5f69504 Compare July 30, 2021 15:21
dhhyi added a commit that referenced this pull request Jul 31, 2021
@dhhyi
fixup! feat: multi-PWA container build with runtime theme switching (#…
fcee07c 
…775)
jometzner
jometzner reviewed Aug 2, 2021
View reviewed changes
Dockerfile Show resolved Hide resolved
@shauke shauke force-pushed the refactor/multi-pwa-container-build branch 2 times, most recently from 2949ebd to 2c03849 Compare August 2, 2021 11:56
jometzner
jometzner reviewed Aug 2, 2021
View reviewed changes
scripts/init-development-environment.js Outdated
const force = process.argv.length > 2 && process.argv.slice(2).find(arg => arg === '-f' || arg === '--force');
const empty = process.argv.length > 2 && process.argv.slice(2).find(arg => arg === '--empty');

const environmentLocalPath = 'src/environments/environment.development.ts';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably only a small thing, but since the whole thing got renamed, we can also rename that variable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"historic footprint" 😅

jometzner pushed a commit that referenced this pull request Aug 3, 2021
@dhhyi @jometzner
feat: multi-PWA container build with runtime theme switching (#775)
5f8d5b6
jometzner pushed a commit that referenced this pull request Aug 3, 2021
@dhhyi @jometzner
fixup! feat: multi-PWA container build with runtime theme switching (#…
841d8c8 
…775)
@jometzner jometzner force-pushed the refactor/multi-pwa-container-build branch from 2c03849 to 9ed0e9d Compare August 3, 2021 08:46
@jometzner jometzner force-pushed the refactor/multi-pwa-container-build branch from 9ed0e9d to d434faf Compare August 3, 2021 09:10
@jometzner jometzner merged commit 302be6d into develop Aug 3, 2021
@jometzner jometzner deleted the refactor/multi-pwa-container-build branch August 3, 2021 09:55
jometzner pushed a commit that referenced this pull request Aug 3, 2021
@dhhyi @jometzner
feat: multi-PWA container build with runtime theme switching (#775)
b4c6060
@jometzner jometzner removed their assignment Aug 3, 2021
@dhhyi dhhyi mentioned this pull request Aug 12, 2021
Merged
@dhhyi dhhyi mentioned this pull request Apr 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

@jometzner jometzner jometzner approved these changes

Assignees
No one assigned
Labels
feature New feature or request refactoring Refactoring of current code research Exploration for fancy new stuff
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dhhyi @jometzner @shauke @rkarl-ish