fix: validation of phone number #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbratsch
requested review from
iwiederhold,
suschneider and
shauke
and removed request for
suschneider
|
Shouldn't there be some sort of validation error message? |
|
Something seems wrong with the regular expression. The following errors are logged to the browser console when entering numbers in the phone input. |
shauke
previously requested changes
Jul 12, 2021
src/app/shared/formly/types/phone-field/phone-field.component.ts
Outdated
Show resolved
Hide resolved
SGrueber
requested changes
Jul 12, 2021
src/app/shared/formly/types/phone-field/phone-field.component.ts
Outdated
Show resolved
Hide resolved
cbratsch
force-pushed
the
bug/validation-for-phone-number
branch
from
4dabe38 to
da50027
Compare
SGrueber
requested changes
Jul 16, 2021
src/app/shared/formly/types/phone-field/phone-field.component.ts
Outdated
Show resolved
Hide resolved
|
docu of the phonefield is missing in formly.md |
cbratsch
pushed a commit
that referenced
this pull request
Jul 16, 2021
cbratsch
force-pushed
the
bug/validation-for-phone-number
branch
from
da50027 to
aa706b4
Compare
M-Behr
previously approved these changes
Jul 16, 2021
cbratsch
force-pushed
the
bug/validation-for-phone-number
branch
from
aa706b4 to
11d6bbc
Compare
SGrueber
previously approved these changes
Jul 19, 2021
cbratsch
pushed a commit
that referenced
this pull request
Jul 19, 2021
cbratsch
force-pushed
the
bug/validation-for-phone-number
branch
from
11d6bbc to
9632591
Compare
SGrueber
previously approved these changes
Jul 20, 2021
iwiederhold
previously approved these changes
Jul 20, 2021
added 2 commits
July 20, 2021 11:02
…de to avoid using existing email addresses
cbratsch
force-pushed
the
bug/validation-for-phone-number
branch
from
9632591 to
75428a6
Compare
M-Behr
approved these changes
Jul 21, 2021
SGrueber
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
input field for for phone number is standard input type text without validation (see issue below for more details)
Issue Number: Closes #424
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#64695