feat: allow translations to be loaded from an external source #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
feature/alternate-localizations-source-translate-manager
branch
4 times, most recently
from
a5fa1d4 to
ccb099c
Compare
shauke
added
wait
|
We are interested in feedback in how many projects would want to use an external translation system instead of the localization functionality of ICM used by default. |
dhhyi
force-pushed
the
feature/alternate-localizations-source-translate-manager
branch
from
ccb099c to
e8185a1
Compare
|
Thank you @dhhyi for this pull request. But for limited request from other projects we will mot merge it into the standard Intershop PWA project and it needs to stay a project customization for you. Sorry for the late response. |
shauke
pushed a commit
that referenced
this pull request
Jul 12, 2022
* docs: add reference to implementation for loading translations from an external source (see #927) BREAKING CHANGES: The @ngx-translate/http-loader has been removed from the dependencies.
shauke
deleted the
feature/alternate-localizations-source-translate-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Translation cannot be loaded from an external source.
ICM translation management has some limitations:
What Is the New Behavior?
An external translation source can be defined.
For testing:
npx http-server src/assets/i18n --corstranslateLoaderUrl: 'http://localhost:8080'inenvironment.development.tstranslateLoaderFormat: '$language_$COUNTRY.json'inenvironment.development.tsDoes this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information
AB#71316