-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make API version to return it's value #248
Conversation
So this would work, but why do we want both |
What about backwards compatibility? If people use |
You may be right, although this looks broken for a while. I would be ok with |
I'm ok with it too. I've updated code accordingly. Tell me if it needs a changelog entry. |
@@ -911,6 +926,9 @@ class CommunicationError < RuntimeError; end | |||
end | |||
end | |||
end | |||
it "should return version" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, the description could help by saying 'should return the latest version set' or something like that.
Code looks good. A changelog entry, yes please. Will merge then. |
Done. Also fixed a typo. |
Merged, thank you for contributing and putting up with my nitpicks :) |
Thank you. Btw, is there a some kind of schedule for releases? |
There's no schedule. I'd like to release maybe next week, but I'd like an implementation for #241 in it, still. |
Regarding #198