Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: prevent creating a request if invalid restrictions #1451

Merged
merged 1 commit into from
Sep 13, 2023
Merged

service: prevent creating a request if invalid restrictions #1451

merged 1 commit into from
Sep 13, 2023

Conversation

jrcastro2
Copy link
Contributor

@jrcastro2 jrcastro2 force-pushed the fix-created-request branch 3 times, most recently from 06800d4 to 1b6c198 Compare September 12, 2023 09:15
@jrcastro2 jrcastro2 marked this pull request as ready for review September 12, 2023 09:16
@zzacharo
Copy link
Member

@jrcastro2 can you put a screenshot to see how is visually the change?

@jrcastro2
Copy link
Contributor Author

@jrcastro2 can you put a screenshot to see how is visually the change?

Yes, sorry forgot to add them! Here they are:
Screenshot from 2023-09-12 09-00-27

Screenshot from 2023-09-12 09-00-05

@jrcastro2 jrcastro2 force-pushed the fix-created-request branch 2 times, most recently from 21b8241 to c67b2cb Compare September 13, 2023 11:34
@jrcastro2
service: prevent creating a request if invalid restrictions
3b6dbcf 
* Community selection modal checks if the community is
  restricted and disables it if the record is public
* closes inveniosoftware/invenio-app-rdm#2384
@zzacharo zzacharo merged commit 801c293 into inveniosoftware:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Created requests displayed in the request search
2 participants
@jrcastro2 @zzacharo