docs: docker #3909
Closed
docs: docker #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
topless
commented
Dec 11, 2018
•
topless
commented
- Initial version of documentation for docker
- Added diagram picturing the build process
- Added docker commands to build containers
- Fixed lint errors in conf.py
- Addresses docs: new section "Infrastructure architecture" #3883
* Removes test coverage badge because it is misleading since Invenio is a container package and hence almost have no code.
ppanero
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
Looks good to me. Maybe just adding a line with the command that needs to be run to build the base image. It might happen that users go to build directly the instance image (The one mentioned for "FunGenerator"), but if they didnt build yet the base it will fail.
|
I have to agree with @ppanero, it's not clear that the |
roksys
approved these changes
Dec 13, 2018
|
|
||
| Among the generated files, there are two Dockerfiles `Dockerfile.base <https://github.com/inveniosoftware/cookiecutter-invenio-instance/blob/master/%7B%7Bcookiecutter.project_shortname%7D%7D/Dockerfile.base>`_ | ||
| and `Dockerfile <https://github.com/inveniosoftware/cookiecutter-invenio-instance/blob/master/%7B%7Bcookiecutter.project_shortname%7D%7D/Dockerfile>`_, | ||
| which are used in that sequence to build the image for your application. |
There was a problem hiding this comment.
in that sequence is this phrase needed?
Co-authored-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
* Initial version of documentation for docker * Added diagram picturing the build process * Added docker commands to build containers * Fixed lint errors in conf.py * Addresses inveniosoftware#3883
topless
force-pushed
the
3883-docs-docker
branch
from
70cb830
to
b8084e1
Compare
kpsherva
approved these changes
Dec 13, 2018
|
Closing PR because it's been stale for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.